Re: [PATCH v1 1/2] platform/x86/amd/pmf: Use existing input event codes to update system states

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 7/6/2024 18:39, Ilpo Järvinen wrote:
> On Tue, 2 Jul 2024, Shyam Sundar S K wrote:
> 
>> At present, the PMF driver employs custom system state codes to update
>> system states. It is recommended to replace these with existing input
> 
> This change entirely removes the way userspace worked before this change?

No. It's still the same way it worked like before; just that we are
removing an additional technical debt of maintaining a separate udev
rules file for kicking in the user-space action.

GNOME folks told that they cannot have a custom actions defined in
udev rules, instead asked to use KEY_SCREENLOCK, KEY_SLEEP,
and KEY_SUSPEND so it entirely matches the behavior.

> We cannot take userspace functionality away like this.
> 

Can you please take a look at PATCH 2/2, that may help to clarify on
why PATCH 1/2 is required.

Thanks,
Shyam




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux