On Mon, 1 Jul 2024, Michael J. Ruhl wrote:
> From: "David E. Box" <david.e.box@xxxxxxxxxxxxxxx>
>
> Some PMT providers require device specific actions before their telemetry
> can be read. Provide assignable PMT read callbacks to allow providers to
> perform those actions.
>
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx>
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/intel/vsec.c | 1 +
> include/linux/intel_vsec.h | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
> index 2b46807f868b..7b5cc9993974 100644
> --- a/drivers/platform/x86/intel/vsec.c
> +++ b/drivers/platform/x86/intel/vsec.c
> @@ -212,6 +212,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he
> intel_vsec_dev->num_resources = header->num_entries;
> intel_vsec_dev->quirks = info->quirks;
> intel_vsec_dev->base_addr = info->base_addr;
> + intel_vsec_dev->priv_data = info->priv_data;
>
> if (header->id == VSEC_ID_SDSI)
> intel_vsec_dev->ida = &intel_vsec_sdsi_ida;
> diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h
> index ff7998cadab4..003301783331 100644
> --- a/include/linux/intel_vsec.h
> +++ b/include/linux/intel_vsec.h
> @@ -67,10 +67,15 @@ enum intel_vsec_quirks {
> VSEC_QUIRK_EARLY_HW = BIT(4),
> };
>
> +struct pmt_callbacks {
> + int (*read_telem)(void *args, u32 guid, u64 *data, u32 count);
> +};
Please add kerneldoc.
> +
> /* Platform specific data */
> struct intel_vsec_platform_info {
> struct device *parent;
> struct intel_vsec_header **headers;
> + void *priv_data;
> unsigned long caps;
> unsigned long quirks;
> u64 base_addr;
Where's the kerneldoc for this struct?
I know you moved things around in the earlier patch, but moving things
into kernel-wide scope comes with a higher standard on documenting things.
--
i.
