On Sunday 23 June 2024 00:36:28 Andy Shevchenko wrote: > On Sat, Jun 22, 2024 at 4:26 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > On 6/22/24 4:20 PM, Pali Rohár wrote: > > > > This is code for special handling required for SMO88xx ACPI devices, > > dell-smo8800 is *the* driver for those ACPI devices. So this code clearly > > belongs here. > > > > According to diffstat this adds about 400 lines of code that is really not > > that big, so I see no urgent reason to introduce weird tricks instead of > > standard driver binding for this. > > This discussion may make me wonder why we don't use > MODULE_DEVICE_TABLE() for this strings, because it's a big advantage > as well of using standard kernel data types and APIs. In example which I sent in <20240622163518.rfm2wa2kzucy7in4@pali> I used MODULE_DEVICE_TABLE with those DMI tables.