Re: [PATCH 1/2] platform/x86: asus-wmi: support camera disable LED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Thanks for the review, Luke.

On 20/06/2024 23.40, Luke Jones wrote:
+ if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_CAMERA_LED)) {
+ asus->camera_led.name = "platform::camera";

What do other devices label their camera LED as? The one I could find appears to use `<vendor>::camera`. So maybe `asus::camera` would be better? This also keeps in line with `asus::kbd_backlight`.

I reasoned it would be better to keep the name generic is so out of the box desktops could toggle the camera and the LED when KEY_CAMERA is pressed, just like with micmute and mute.

But I'll submit a new version with just this patch and the name change.

~ Dev




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux