Re: [PATCH v2 0/3] power: supply: power-supply-leds: Add activate() callback to triggers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 31, 2024 at 4:47 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Hi All,
>
> This series adds an activate callback to the power-supply LED triggers to
> ensure that power-supply LEDs get the correct initial value when the LED
> gets registered after the power_supply has been registered.
>
> Note that in 6.10-rc1 commit 822c91e72eac ("leds: trigger: Store brightness
> set by led_trigger_event()") already solves this for the case were
> the trigger only changes only the brightness. Since the power-supply
> triggers can also set blinking and colors of mc LEDs that is not enough.
>
> Patches 1-2 do some refactoring / prep work and patch 3 adds the actual
> activate callback.
>
> This series applies on top of 6.10-rc1 + "[PATCH v10 0/6] KTD2026 indicator
> LED for X86 Xiaomi Pad2" that series should show up in
> https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/
>
> soon, since this is also LED related I guess this could be merged
> through the LED tree too. Or Lee could provide an IB branch for
> Sebastian to merge that branch + this series through the psy tree.
> Sebastian, what has your preference ?

FWIW, LGTM,
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux