On 24/05/2024 16:39, Joel Selvaraj via B4 Relay wrote: > From: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > > Document the Novatek NVT touchscreen controller present in devices like > the Xiaomi Poco F1 [1]. Also, include the devictree binding file in the Just name the DTS, no need for external link. > MAINTAINERS file. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts?h=v6.9 > > + > + vcc-supply: true > + iovcc-supply: true > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + touchscreen@1 { > + compatible = "novatek,nt36672a-ts"; Messed indentation. Use 4 spaces for example indentation. With above fixes: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
