On Wed, May 22, 2024 at 10:32 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Wed, May 22, 2024 at 9:40 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > On 5/22/24 7:19 PM, Andy Shevchenko wrote: > > > On Wed, May 22, 2024 at 06:48:07PM +0200, Hans de Goede wrote: ... > > next_arg is meant for parsing different arguments on the kernel cmdline > > split by spaces. It has space as separator hardcoded so it cannot be > > used here. > > I believe it's not the first time I hear such an excuse for > duplicating Yet Another (Same) Parser. > If you think you really need another separator, we may patch > next_arg() or add next_arg_any(is_separator_fn *fn) and make > next_arg() to be a wrapper of the other one. Also note, that it will allow (AFAIU) to have something like xy="xy,inverted" to be passed if needed in the future. -- With Best Regards, Andy Shevchenko
