Hi,
On 5/4/24 6:41 PM, Hans de Goede wrote:
> From: Kate Hsuan <hpa@xxxxxxxxxx>
>
> Xiaomi pad2 RGB LED fwnode updates:
>
> 1. Set "label" instead "function" to change the LED classdev name from
> "rgb:indicator" to "i2c-ktd2026:rgb:indicator" to match the usual
> triplet name format for LED classdevs.
>
> 2. Set the trigger to the new "bq27520-0-charging-orange-full-green"
> powersupply trigger type for multi-color LEDs.
>
> 3. Put the fwnode link for red before green in ktd2026_node_group[] so that
> multi_index becomes "red green blue".
>
> Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
> Co-developed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
> ---
> drivers/platform/x86/x86-android-tablets/other.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/x86-android-tablets/other.c b/drivers/platform/x86/x86-android-tablets/other.c
> index ce487b3c972c..198ea894d071 100644
> --- a/drivers/platform/x86/x86-android-tablets/other.c
> +++ b/drivers/platform/x86/x86-android-tablets/other.c
> @@ -609,8 +609,8 @@ static const struct software_node ktd2026_node = {
> static const struct property_entry ktd2026_rgb_led_props[] = {
> PROPERTY_ENTRY_U32("reg", 0),
> PROPERTY_ENTRY_U32("color", LED_COLOR_ID_RGB),
> - PROPERTY_ENTRY_STRING("function", "indicator"),
> - PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging"),
> + PROPERTY_ENTRY_STRING("label", "i2c-ktd2026:rgb:indicator"),
> + PROPERTY_ENTRY_STRING("linux,default-trigger", "bq27520-0-charging-orange-full-green"),
> { }
> };
>
> @@ -656,9 +656,9 @@ static const struct software_node ktd2026_red_led_node = {
> static const struct software_node *ktd2026_node_group[] = {
> &ktd2026_node,
> &ktd2026_rgb_led_node,
> + &ktd2026_red_led_node,
> &ktd2026_green_led_node,
> &ktd2026_blue_led_node,
> - &ktd2026_red_led_node,
> NULL
> };
>
