On Mon, 13 May 2024, Andy Shevchenko wrote: > On Mon, May 13, 2024 at 12:01:55PM +0200, Hans de Goede wrote: > > On 5/12/24 9:35 PM, Andy Shevchenko wrote: > > > On Sun, May 12, 2024 at 7:24 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > ... > > > >> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > > > > How is this being used? > > > > #include "../serdev_helpers.h" > > > > uses this. > > Yet another evidence why C code in the *.h is not a good idea. get_serdev_controller() function is quite complex anyway to be inlined, and if there's going to be another user now, it should be uninlined. -- i.
