Hi, On 5/12/24 9:32 PM, Andy Shevchenko wrote: > On Sun, May 12, 2024 at 7:24 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Dell All In One (AIO) models released after 2017 use a backlight controller >> board connected to an UART. >> >> Add a small emulator to allow development and testing of >> the drivers/platform/x86/dell/dell-uart-backlight.c driver for >> this board, without requiring access to an actual Dell All In One. > > ... > >> +++ b/tools/arch/x86/dell-uart-backlight-emulator/Makefile >> @@ -0,0 +1,19 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +# Makefile for Intel Software Defined Silicon provisioning tool >> + >> +dell-uart-backlight-emulator: dell-uart-backlight-emulator.c >> + >> +BINDIR ?= /usr/bin >> + >> +override CFLAGS += -O2 -Wall >> + >> +%: %.c >> + $(CC) $(CFLAGS) -o $@ $< $(LDFLAGS) >> + >> +.PHONY : clean >> +clean : >> + @rm -f dell-uart-backlight-emulator >> + >> +install : dell-uart-backlight-emulator >> + install -d $(DESTDIR)$(BINDIR) >> + install -m 755 -p dell-uart-backlight-emulator $(DESTDIR)$(BINDIR)/dell-uart-backlight-emulator > > Is it possible to fix this to (at least) honour `make O=...` cases? > (See, e.g., tools/gpio.) I have taken a look but this only seems applicable to tools which are listed in tools/Makefile which includes scripts/Makefile.include. this are mostly tools which distributions may want to package as part of a kernel-tools package. I don't expect distros to package this, so this seems to not be applicable to this emulator. Regards, hans
