On 5/10/24 06:30, Andy Shevchenko wrote:
On Fri, May 10, 2024 at 1:19 AM Armin Wolf <W_Armin@xxxxxx> wrote:
Currently, the driver does only support a custom sysfs
interface to allow userspace to read the fan speed.
Add support for the standard hwmon interface so users
can read the fan speed with standard tools like "sensors".
Tested with a custom ACPI SSDT.
This most likely fits the comment/changelog area and not the commit
message. Also would be good to put there the link to this custom SSDT
(like one of zillion of pastebin sites, or GitHub, or ...).
I was under the impression that Guenter gave a tag, which is missing,
but no, he just said it's okay to go. Guenter, maybe a formal
Acked-by?
I said
It all seems odd, and I returning -ENODATA doesn't seem right,
but then I don't understand the specification or the logic behind it, and
I don't have the time to read and understand it. No objection from my side
against moving forward.
This isn't sufficient for anything formal. Just go ahead.
Thanks,
Guenter
