On Fri, May 3, 2024 at 12:14 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > Here is v8 of Kate's series to add support for Xiaomi Pad2 indicator LED. > > I believe this is ready for merging now. Patch 6/7 has an Acked-by from > Sebastien for merging this patch through the leds tree since it depends > on the earlier patches. LEDs tree maintainers please merge patches 1-6, > then patch 7 can be merged through the pdx86 tree indepdently. independently > > This work includes: > 1. Added the KTD2026 swnode description to describe the LED controller. > 2. Migrated the original driver to fwnode to support x86 platform. > 3. Support for multi-color LED trigger event. for a / events > 4. The LED shows orange when charging and the LED shows green when the > battery is full. > > Moreover, the LED trigger is set to the new trigger, called > "bq27520-0-charging-orange-full-green" for Xiaomi Pad2 so the LED shows > orange when charging and the LED shows green when the battery is full. Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> One comment regarding use of devm_mutex_init() instead. -- With Best Regards, Andy Shevchenko