Hi All, On 4/24/24 8:52 AM, Kate Hsuan wrote: > This patch added the support for Xiaomi Pad2 indicator LED. This work > included: > 1. Added the KTD2026 swnode description to describe the LED controller. > 2. Migrated the original driver to fwnode to support x86 platform. > 3. Support for multi-color LED trigger event. > 4. The LED shows orange when charging and the LED shows green when the > battery is full. > > Moreover, the LED trigger is set to the new trigger, called > "bq27520-0-charging-orange-full-green" for Xiaomi Pad2 so the LED shows > orange when charging and the LED shows green when the battery is full. Lee, I believe this series is ready for merging now ? I've reviewed patches 1-2 + 5 and Jacek has reviewed patches 3 + 4. Patch 5 also has an Acked-by from Sebastian for merging it together with the rest of the series. Can you merge patches 1-5 ? Patch 6 just changes the value of a device-property (the default-trigger string) and I can merge that through the pdx86 tree independent of patches 1-5. Regards, Hans > > -- > Changes in v7: > 1. Platform: x86-android-tablets: other: Add swnode for Xiaomi pad2 > indicator LED was included in Hans' branch. > 2. Included the tags from the previous version in the commit message. > 3. Fixed the comma issue for the structure initialiser. > > Changes in v6: > 1. The I2C ID table was moved to a separate patch. > 2. The LED shows orange when charging. > 3. The trigger name was renamed to charging-orange-full-green. > 4. The default trigger of Xiaomi Pad2 is > "bq27520-0-charging-orange-full-green". > > Changes in v5: > 1. Fix swnode LED color settings. > 2. Improve the driver based on the comments. > 3. Introduce a LED new API- led_mc_trigger_event() to make the LED > color can be changed according to the trigger. > 4. Introduced a new trigger "charging-red-full-green". The LED will be > red when charging and the the LED will be green when the battery is > full. > 5. Set the default trigger to "bq27520-0-charging-red-full-green" for > Xiaomi Pad2. > > Changes in v4: > 1. Fix double casting. > 2. Since force casting a pointer value to int will trigger a compiler > warning, the type of num_leds was changed to unsigned long. > > Changes in v3: > 1. Drop the patch "leds-ktd202x: Skip regulator settings for Xiaomi > pad2" > > Changes in v2: > 1. Typo and style fixes. > 2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since > KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the > sleep can be removed when removing the module. > > > Hans de Goede (2): > leds: core: Add led_mc_set_brightness() function > leds: trigger: Add led_mc_trigger_event() function > > Kate Hsuan (4): > leds: rgb: leds-ktd202x: Get device properties through fwnode to > support ACPI > leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027 > power: supply: power-supply-leds: Add charging_orange_full_green > trigger for RGB LED > platform: x86-android-tablets: others: Set the LED trigger to > charging_orange_full_green for Xiaomi pad2 > > drivers/leds/led-class-multicolor.c | 1 + > drivers/leds/led-core.c | 31 ++++++++ > drivers/leds/led-triggers.c | 20 ++++++ > drivers/leds/rgb/Kconfig | 1 - > drivers/leds/rgb/leds-ktd202x.c | 72 +++++++++++-------- > .../platform/x86/x86-android-tablets/other.c | 2 +- > drivers/power/supply/power_supply_leds.c | 26 +++++++ > include/linux/leds.h | 26 +++++++ > include/linux/power_supply.h | 2 + > 9 files changed, 149 insertions(+), 32 deletions(-) >
