Hi, On 4/24/24 8:52 AM, Kate Hsuan wrote: Maybe start the commit message with: Add an i2c_device_id id_table to match manually instantiated (non device-tree / ACPI instantiated) KTD202x controllers as found on some x86 boards. ? > This table shows the maximum support LED channel for KTD2026 and KTD-2027. > The 3-channel LED controller KTD2026 controls R/G/B three LEDs. The > 4-channel LED controller KTD2027 controls R/G/B and flashing LEDs. Other then that this looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > > Datasheet: https://www.kinet-ic.com/uploads/KTD2026-7-04h.pdf > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx> > --- > drivers/leds/rgb/leds-ktd202x.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/leds/rgb/leds-ktd202x.c b/drivers/leds/rgb/leds-ktd202x.c > index f1c810c415a4..60ca6ec34336 100644 > --- a/drivers/leds/rgb/leds-ktd202x.c > +++ b/drivers/leds/rgb/leds-ktd202x.c > @@ -606,6 +606,13 @@ static void ktd202x_shutdown(struct i2c_client *client) > regmap_write(chip->regmap, KTD202X_REG_RESET_CONTROL, KTD202X_RSTR_RESET); > } > > +static const struct i2c_device_id ktd202x_id[] = { > + {"ktd2026", KTD2026_NUM_LEDS}, > + {"ktd2027", KTD2027_NUM_LEDS}, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, ktd202x_id); > + > static const struct of_device_id ktd202x_match_table[] = { > { .compatible = "kinetic,ktd2026", .data = (void *)KTD2026_NUM_LEDS }, > { .compatible = "kinetic,ktd2027", .data = (void *)KTD2027_NUM_LEDS }, > @@ -621,6 +628,7 @@ static struct i2c_driver ktd202x_driver = { > .probe = ktd202x_probe, > .remove = ktd202x_remove, > .shutdown = ktd202x_shutdown, > + .id_table = ktd202x_id, > }; > module_i2c_driver(ktd202x_driver); >
