Hi Mario, On 4/23/24 7:07 PM, Mario Limonciello wrote: > On 4/23/2024 04:14, Suma Hegde wrote: >> Patch1: >> The first patch is to address the concerns mentioned by Limonciello, >> Mario i.e to address the issue of >> "Probing registers that don't match the same mailboxes randomly on >> client or embedded parts might lead to unexpected behaviors". >> >> Because of some limitations, instead of the methods suggested by Mario, >> family check is added to differentiate server socs and client socs. >> This check is only for backward compatibility, Going forward all >> systems will have ACPI based probing only. >> > > Thanks! Hans, please drop the PM profile patch from your review queue in favor of this series instead. You mean: "platform/x86/amd: Don't allow HSMP to be loaded on non-server hardware", right ? now dropped. Regards, Hans > >> >> Patch2: >> The second patch splits ACPI code into separate file there by removing the >> dependency of ACPI in Kconfig. >> This is based on the suggestion from Ilpo Jarvinen. >> >> >> Patch3: >> The third patch makes HSMP as "default m" so that anyone who uses standard >> distros will be able to use HSMP by dynamically loading it. >> >> >> Suma Hegde (3): >> platform/x86/amd/hsmp: Check HSMP support on AMD family of processors >> platform/x86/amd/hsmp: Split the ACPI and non-ACPI code >> platform/x86/amd/hsmp: Make HSMP as default m >> >> MAINTAINERS | 2 +- >> drivers/platform/x86/amd/Kconfig | 14 +- >> drivers/platform/x86/amd/Makefile | 3 +- >> drivers/platform/x86/amd/hsmp/Kconfig | 18 + >> drivers/platform/x86/amd/hsmp/Makefile | 9 + >> drivers/platform/x86/amd/hsmp/hsmp-acpi.c | 219 ++++++++++++ >> drivers/platform/x86/amd/{ => hsmp}/hsmp.c | 378 +++++---------------- >> drivers/platform/x86/amd/hsmp/hsmp.h | 82 +++++ >> 8 files changed, 425 insertions(+), 300 deletions(-) >> create mode 100644 drivers/platform/x86/amd/hsmp/Kconfig >> create mode 100644 drivers/platform/x86/amd/hsmp/Makefile >> create mode 100644 drivers/platform/x86/amd/hsmp/hsmp-acpi.c >> rename drivers/platform/x86/amd/{ => hsmp}/hsmp.c (71%) >> create mode 100644 drivers/platform/x86/amd/hsmp/hsmp.h >> >