Re: [PATCH 3/3] platform/x86/amd/hsmp: Make HSMP as default m

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mario,

On 4/23/2024 10:47 PM, Mario Limonciello wrote:
On 4/23/2024 04:14, Suma Hegde wrote:
Making HSMP as "default m" in Kconfig, enables customers
who rely on the standard distros to use the HSMP by dynamically
loading it.

Signed-off-by: Suma Hegde <suma.hegde@xxxxxxx>
Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@xxxxxxx>
---
  drivers/platform/x86/amd/hsmp/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/amd/hsmp/Kconfig b/drivers/platform/x86/amd/hsmp/Kconfig
index 26096f901c22..9d3f422b3f81 100644
--- a/drivers/platform/x86/amd/hsmp/Kconfig
+++ b/drivers/platform/x86/amd/hsmp/Kconfig
@@ -6,6 +6,7 @@
  config AMD_HSMP
      tristate "AMD HSMP Driver"
      depends on AMD_NB && X86_64
+    default m

I don't think Linus likes to see things default to 'm'.  I don't see anything in the platform-x86 subsystem that is defaulted 'm'.

IMO It's better to request the distros to enable it.

Ok, then we will request the distros to enable it.

Hans, request you to drop this patch.

      help
        The driver provides a way for user space tools to monitor and manage
        system management functionality on EPYC server CPUs from AMD.

Thanks and Regards,

Suma





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux