On Sun, Apr 21, 2024 at 6:45 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Change the default keymap to report the correct keycodes for the volume and > brightness keys. Reporting key events for these is already filtered out by > the hotkey_reserved_mask which masks these keys out of hotkey_user_mask at > initialization time, so there is no need to also map them to KEY_RESERVED. > > This avoids users, who want these to be reported, having to also remap > the keycodes on top of overriding hotkey_user_mask to report these > and Linux userspace has already been overridding the KEY_RESERVED mappings overriding > with the correct keycodes through udev/hwdb/60-keyboard.hwdb for years now. > > Also drop hotkey_unmap() it was only used to dynamically map the brightness > keys to KEY_RESERVED and after removing that it has no remaining users. ... > + /* brightness: firmware always reacts to them. > + * Suppressed by default through hotkey_reserved_mask. > + */ > + /* Thinklight: firmware always react to it. > + * Suppressed by default through hotkey_reserved_mask. > + */ > /* Volume: firmware always react to it and reprograms > * the built-in *extra* mixer. Never map it to control > + * another mixer by default. > + * Suppressed by default through hotkey_reserved_mask. > + */ Hmm... While at it, can we rectify the block comments to follow the standard style? (I meant those which you are touching here.) -- With Best Regards, Andy Shevchenko
