Hi Andy On Wed, Apr 17, 2024 at 1:32 AM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Tue, Apr 16, 2024 at 8:40 AM Kate Hsuan <hpa@xxxxxxxxxx> wrote: > > > > This table shows the maximum support LED channel for KTD2026 and KTD-2027. > > The 3-channel LED controller KTD2026 controls R/G/B three LEDs. The > > 4-channel LED controller KTD2027 controls R/G/B and a flashing LEDs. > > and flashing LEDs should be LED. > > ... > > > Link: https://www.kinet-ic.com/uploads/KTD2026-7-04h.pdf > > Make it Datasheet: tag Okay > > > > > and drop this blank line (to ensure the Datasheet will be recognised as a tag). Okay > > > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx> > > ... > > > - .shutdown = ktd202x_shutdown > > + .shutdown = ktd202x_shutdown, > > + .id_table = ktd202x_id > > Exactly good example to show what the difference is between > "terminator entry" and "last field in the initialiser" and why in the > latter it's better to keep a trailing comma. And hence why the stray > change in the previous patch. So, id_table also should keep a trailing > comma. Thank you for reviewing it. Lesson learned. Now I know how to manipulate the comma correctly. > > -- > With Best Regards, > Andy Shevchenko > -- BR, Kate
