On Tue, Apr 16, 2024 at 8:39 AM Kate Hsuan <hpa@xxxxxxxxxx> wrote: > > KTD2026 LED controller manages the indicator LED for Xiaomi pad2. The ACPI > for it is not properly made so the kernel can't get a correct description. > > This work adds a description for this RGB LED controller and also sets a > trigger to indicate the changing event (bq27520-0-charging). When it is > charging, the indicator LED will be turned on. ... > +/* > + * The fwnode for ktd2026 on Xaomi pad2. It composed of a RGB LED node is composed > + * with three subnodes for each color. The RGB LED node is named > + * "multi-led" to align with the name in the device tree. > + */ ... > +static const struct software_node ktd2026_node = { > + .name = "ktd2026" Please, leave a trailing comma as it's not a termination entry. > +}; (TBH I'm still unsure that having a name is a good idea even if it's supposed to be only a single device on the platform, but it's up to Hans who has an experience with those.) -- With Best Regards, Andy Shevchenko