On 4/10/24 7:10 AM, Mario Limonciello wrote: > If the HSMP driver is compiled into the kernel it can cause problems > on systems that support PMC since it probes hardware it shouldn't. > > Prevent users from compiling HSMP as built-in when PMC is enabled. > > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2414 > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3285 > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > --- > drivers/platform/x86/amd/pmc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/pmc/Kconfig b/drivers/platform/x86/amd/pmc/Kconfig > index 883c0a95ac0c..d734f6698f97 100644 > --- a/drivers/platform/x86/amd/pmc/Kconfig > +++ b/drivers/platform/x86/amd/pmc/Kconfig > @@ -7,6 +7,7 @@ config AMD_PMC > tristate "AMD SoC PMC driver" > depends on ACPI && PCI && RTC_CLASS && AMD_NB > depends on SUSPEND > + depends on (AMD_HSMP = n) || (AMD_HSMP = m) Can't you use depends on AMD_HSMP!=y ? > select SERIO > help > The driver provides support for AMD Power Management Controller -- Sathyanarayanan Kuppuswamy Linux Kernel Developer
