Hi, On 3/29/24 6:43 PM, Andy Shevchenko wrote: > Fri, Mar 29, 2024 at 01:23:25AM +0100, Armin Wolf kirjoitti: >> Am 28.03.24 um 09:50 schrieb Andy Shevchenko: >>> On Thu, Mar 28, 2024 at 1:35 AM Armin Wolf <W_Armin@xxxxxx> wrote: >>>> Am 27.03.24 um 22:52 schrieb Andy Shevchenko: > > ... > >>>>> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >>>> that is the reason for removing this? >>> Yes, it's a dead code. Likely the cargo cult line was copied from >>> another driver. >>> >> In that case: Reviewed-by: Armin Wolf <W_Armin@xxxxxx> > > Thank you! > > You need to use a whole line for the tag. > > P.S. > It seems Hans hadn't folded anything from here, so I will send a patch > (series?) next week. Sorry about being a bit slow with merging this. I usually process the pdx86 patch-queue on Monday and last Monday was a bank holiday. I'm merging this (and the other quickstart driver fixes) today: Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans
