On 03/04/2024 10:39, Hans de Goede wrote: >>> >>> must have a dts user before being approved too ? Since >>> that file is included from include/dt-bindings/input/input.h ? >> >> Wait, that's UAPI :) and we just share the constants. That's kind of >> special case, but I get what you mean. >> >>> >>> TL;DR: not only is this patch fine, this is actually >>> the correct place to add such a define according to >>> the docs in Documentation/leds/leds-class.rst : >>> >>> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Thanks. Is it ok for me to merge this through the pdx86 > tree (once I've reviewed the other 2 patches) ? You need to sync (ack) with LED folks, because by default this should go via LED subsystem. Best regards, Krzysztof
