Re: [PATCH 1/3] dt-bindings: leds: add LED_FUNCTION_FNLOCK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 02/04/2024 16:36, Gergo Koteles wrote:
> Hi Krzysztof,
> On Tue, 2024-04-02 at 15:55 +0200, Krzysztof Kozlowski wrote:
>> Do we really need to define all these possible LED functions? Please
>> link to DTS user for this.
> I think for userspace it's easier to support an LED with a specified
> name than to use various sysfs attributes. LED devices are easy to find
> because they available are in the /sys/class/leds/ directory.
> So I think it's a good thing to define LED names somewhere.

You did not add anything for user-space, but DT bindings. We do not keep
here anything for user-space.

> J Luke missed this LED from /sys/class/leds/, that's where the idea
> came from. The scrollock, numlock, capslock and kbd_backlight LEDs are
> already exported.

I see there sysfs, so what does it have to do with bindings?

Again, please link to in-tree or in-review DTS.

Best regards,

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux