On Wed, Mar 27, 2024 at 09:03:38PM +0100, Hans de Goede wrote: > On 3/27/24 2:14 PM, Andy Shevchenko wrote: > > On Wed, Mar 27, 2024 at 11:54:55AM +0100, Hans de Goede wrote: > >> On 3/26/24 3:54 AM, 艾超 wrote: ... > >>>>> +config LENOVO_WMI_CAMERA > >>>>> + tristate "Lenovo WMI Camera Button driver" > >>>>> + depends on ACPI_WMI > >>>>> + depends on INPUT > >>> > >>>> No COMPILE_TEST? > >>> > >>> I compile this driver and used Evtest tool to test it on lenovo A70. > > > > What I meant here is to add respective COMPILE_TEST to the dependency(ies). > > Neither include/linux/input.h nor include/linux/wmi.h offer > stubs when disabled so this will not work. Oh, I didn't realize that! > Besides x86 has a lot of compile test coverage in general, > so I don't see much value in adding || COMPILE_TEST to > dependencies. Agree. -- With Best Regards, Andy Shevchenko
