On 3/27/24 12:57 PM, Hans de Goede wrote:
> When logging the warning about receiving a button event on a device
> without buttons log the event code which triggered the warning.
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
Looks good to me.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> drivers/platform/x86/intel/vbtn.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c
> index 084c355c86f5..de4decbb13ba 100644
> --- a/drivers/platform/x86/intel/vbtn.c
> +++ b/drivers/platform/x86/intel/vbtn.c
> @@ -158,7 +158,8 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
>
> if ((ke = sparse_keymap_entry_from_scancode(priv->buttons_dev, event))) {
> if (!priv->has_buttons) {
> - dev_warn(&device->dev, "Warning: received a button event on a device without buttons, please report this.\n");
> + dev_warn(&device->dev, "Warning: received 0x%02x button event on a device without buttons, please report this.\n",
> + event);
> return;
> }
> input_dev = priv->buttons_dev;
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
