Hi Hans, On Tue, Mar 26, 2024 at 12:32 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > > On Mon, Mar 25, 2024 at 04:02:54PM +0100, Hans de Goede wrote: > > On 3/22/24 4:37 AM, Kate Hsuan wrote: > > > There is a KTD2026 LED controller to manage the indicator LED for Xiaomi > > > pad2. The ACPI for it is not properly made so the kernel can't get > > > a correct description of it. > > > > > > This work add a description for this RGB LED controller and also set a > > > trigger to indicate the chaging event (bq27520-0-charging). When it is > > > charging, the indicator LED will be turn on. > > > > > > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx> > > > > Thank you for your patch, I've applied this patch to my review-hans > > branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > > > I will also merge [PATCH v5 6/6] platform: x86-android-tablets: > > others: Set the LED trigger to charging_red_full_green for Xiaomi pad2" > > > > Once the new power_supply trigger patch this relies on has been > > accepted. > > > > Once I've run some tests on this branch the patches there will be > > added to the platform-drivers-x86/for-next branch and eventually > > will be included in the pdx86 pull-request to Linus for the next > > merge-window. > > I believe I have commented on the "RESEND" version. > Thank you for your reviewing. Please review the RESEND patch and I'll fix them according to Andy's comments. > -- > With Best Regards, > Andy Shevchenko > > -- BR, Kate
