Re: [PATCH 0/2] platform/x86: Add ACPI quickstart button driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Am 24.03.24 um 15:55 schrieb Hans de Goede:

Hi Armin and Arvid,

On 1/31/24 12:16 PM, Armin Wolf wrote:
This patch series adds support for the ACPI PNP0C32 device as
proposed in 2022 by Arvid Norlander. The first patch adds support
for the device itself, while the second patch was taken from the
original series.

Both patches are compile-tested only.
Armin, thank you for creating a new cleaned up driver for the
quickstart button support.

I have managed to get my hands on a Toshiba Portege Z830 and
I have successfully tested this series. That is this makes
the 2 quickstart application and the toggle-touchpad button
work when the system is running normally.

Neither the quickstart buttons, nor the touchpad-toggle button
which also uses the PNP0C32 interface, work to wakeup
the system from sleep though.

I've also review both patches and they look good to me:

Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

So I plan to merge this series into pdx86/for-next once
6.9-rc1 is out.




great to hear that the driver works. Can you send me the output of "acpidump" on this machine?
Maybe the quickstart buttons have no wake capabilities?

Armin Wolf

Armin Wolf (1):
   platform/x86: Add ACPI quickstart button (PNP0C32) driver

Arvid Norlander (1):
   platform/x86: toshiba_acpi: Add quirk for buttons on Z830

  MAINTAINERS                         |   6 +
  drivers/platform/x86/Kconfig        |  13 ++
  drivers/platform/x86/Makefile       |   3 +
  drivers/platform/x86/quickstart.c   | 225 ++++++++++++++++++++++++++++
  drivers/platform/x86/toshiba_acpi.c |  36 ++++-
  5 files changed, 280 insertions(+), 3 deletions(-)
  create mode 100644 drivers/platform/x86/quickstart.c


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux