On Mon, Mar 11, 2024 at 12:53:36PM +0200, Ilpo Järvinen wrote: > On Sat, 9 Mar 2024, Dmitry Torokhov wrote: > > > On Mon, Feb 26, 2024 at 03:27:33PM +0200, Ilpo Järvinen wrote: > > > On Tue, 20 Feb 2024 04:39:34 +0100, Gergo Koteles wrote: > > > > > > > This patch series adds a new KEY_FN_R input event code and map the > > > > Fn + R key to it in the ideapad-laptop driver. > > > > > > > > It affects two WMI keycodes and I couldn't try the 0x0a, but I couldn't > > > > find any indication that the refresh rate toggle should not be Fn + R. > > > > > > > > Regards, > > > > Gergo > > > > > > > > [...] > > > > > > > > > Thank you for your contribution, it has been applied to my local > > > review-ilpo branch. Note it will show up in the public > > > platform-drivers-x86/review-ilpo branch only once I've pushed my > > > local branch there, which might take a while. > > > > > > The list of commits applied: > > > [1/2] Input: allocate keycode for Fn + R > > > commit: 4e45fa464aeef4e803412b5dcce73aad48c94b0e > > > > I am sorry for the delay, but instead of defining a generic name we should define > > a proper keycode for concrete action even if nothing is printed on a > > particular key on a particular device. > > > > Please drop this patch. > > Dropping them at this point would bit of a hassle due to backmerges of > fixes branch. You should really wait applying patches affecting other parts of the kernel as well as UAPI until all maintainers responsible for them agree with the changes. Thanks. -- Dmitry
