Re: [PATCH vhost 2/4] virtio: vring_create_virtqueue: pass struct instead of multi parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, 2024-03-04 at 19:47 +0800, Xuan Zhuo wrote:
> Now, we pass multi parameters to vring_create_virtqueue. These parameters
> may from transport or from driver.
> vring_create_virtqueue is called by many places.
> Every time, we try to add a new parameter, that is difficult.
> If parameters from the driver, that should directly be passed to vring.
> Then the vring can access the config from driver directly.
> If parameters from the transport, we squish the parameters to a
> structure. That will be helpful to add new parameter.
> Because the virtio_uml.c changes the name, so change the "names" inside
> the virtio_vq_config from "const char *const *names" to
> "const char **names".
> Signed-off-by: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>
> ---
>  arch/um/drivers/virtio_uml.c       | 14 +++++---

Looks fine here.

Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux