On Thu, 29 Feb 2024 16:11:36 +0300, Dan Carpenter wrote: > These need to be signed for the error handling to work. The > mlxbf_pmc_get_event_num() function returns int so int type is correct. > > Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/1] platform/mellanox: mlxbf-pmc: fix signedness bugs commit: d22168db08c4c8e6c5e25fa3570f50f0f2ff1ef1 -- i.