Hi Hans and Mark,
Thanks for the review.
On Thu, Feb 29, 2024 at 5:19 AM Mark Pearson <mpearson-lenovo@xxxxxxxxx> wrote:
>
> Hi Hans,
>
> On Wed, Feb 28, 2024, at 11:09 AM, Hans de Goede wrote:
> > Hi,
> >
> > On 2/28/24 16:01, Vishnu Sankar wrote:
> >> Add more ThinkPads with non-standard register addresses to read fan values.
> >>
> >> ThinkPads added are L13 Yoga Gen1, X13 Yoga Gen1, L380, L390, 11e Gen5 GL,
> >> 11e Gen5 GL-R, 11e Gen5 KL-Y.
> >>
> >> Signed-off-by: Vishnu Sankar <vishnuocv@xxxxxxxxx>
> >
> > Thanks, I have no objection against this patch:
> >
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> >
> > But this feels like it will become a game of whack-a-mole.
> >
> > Mark can you reach out to the ThinkPad firmware team and
> > figure out if there is some supported way to automatically detect
> > this ?
> >
> These are all older platforms and we're not expecting to see this on any newer platforms...if it shows up it's because they messed up (there is a spec and they're supposed to follow it).
> Vishnu did review with the FW team which platforms had used this implementation, and we believe the list below to be complete.
>
> Vishnu, please correct me if you've heard otherwise.
This is confirmed by the FW team.
The list of systems is complete and no more systems are expected (as of now).
>
> As a note, I did review this during an internal review, before Vishnu pushed it, so I'll add:
>
> Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
>
> Mark
--
Regards,
Vishnu Sankar
+817015150407 (Japan)
