On Wed, Feb 28, 2024 at 3:10 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 2/27/24 22:40, Pali Rohár wrote: > > On Saturday 17 February 2024 11:33:21 Hans de Goede wrote: > >> On 2/13/24 17:30, Jean Delvare wrote: ... > >> The i801 device is not hotplugable, so normally this will never > >> happen. If the user manually unbinds + rebinds the i2c-i801 driver > >> them the i2c_client for the smo88xx device will indeed get removed > >> and not re-added. But this will normally never happen and if > >> a user is manually poking things then the user can also unbind + > >> rebind the dell-mso8800 driver after the i2c-i801 rebind. > >> So I don't really see this as an issue. > > > > Well, rmmod & modprobe is not the rare cases. Whatever developers say > > about rmmod (or modprobe -r or whatever is the way for unloading > > modules), this is something which is used by a lot of users and would be > > used. > > Many modules actually have bugs in there remove paths and crash, > this is really not a common case. Sometimes users use rmmod + modprobe > surrounding suspend/resume for e.g. a wifi driver to work around > suspend/resume problems but I have never heard of this being used > for a driver like i2c-i801. Hmm... The whole thing of reworking the p2sb was done due to rebounding the i2c-i801 IIUC. -- With Best Regards, Andy Shevchenko