Re: [PATCH 2/7] platform/x86/amd/pmf: Disable debugfs support for querying power thermals

[Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>]

On 2/27/2024 21:25, Kuppuswamy Sathyanarayanan wrote:
> 
> On 2/27/24 4:55 AM, Shyam Sundar S K wrote:
>> The GET interface to receive the active power thermal information from
>> the PMFW has been depricated. Hence drop the debugfs support for the
>> newer platforms.
> 
> Instead of "newer platforms", I recommend to use version numbers.
> 
> IIUC, you don't want to expose it for ver > 1.

OK. I will change it.

Thanks,
Shyam

> 
>>
>> Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@xxxxxxx>
>> Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@xxxxxxx>
>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
>> ---
>>  drivers/platform/x86/amd/pmf/core.c | 5 +++--
>>  drivers/platform/x86/amd/pmf/pmf.h  | 2 ++
>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
>> index 4f734e049f4a..2230bc2b1f59 100644
>> --- a/drivers/platform/x86/amd/pmf/core.c
>> +++ b/drivers/platform/x86/amd/pmf/core.c
>> @@ -113,8 +113,9 @@ static void amd_pmf_dbgfs_unregister(struct amd_pmf_dev *dev)
>>  static void amd_pmf_dbgfs_register(struct amd_pmf_dev *dev)
>>  {
>>  	dev->dbgfs_dir = debugfs_create_dir("amd_pmf", NULL);
>> -	debugfs_create_file("current_power_limits", 0644, dev->dbgfs_dir, dev,
>> -			    &current_power_limits_fops);
>> +	if (dev->pmf_if_version == PMF_IF_V1)
>> +		debugfs_create_file("current_power_limits", 0644, dev->dbgfs_dir, dev,
>> +				    &current_power_limits_fops);
>>  }
>>  
>>  int amd_pmf_get_power_source(void)
>> diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h
>> index e51ac981af73..4364af72a7a3 100644
>> --- a/drivers/platform/x86/amd/pmf/pmf.h
>> +++ b/drivers/platform/x86/amd/pmf/pmf.h
>> @@ -83,6 +83,8 @@
>>  #define TA_OUTPUT_RESERVED_MEM				906
>>  #define MAX_OPERATION_PARAMS					4
>>  
>> +#define PMF_IF_V1		1
>> +
>>  /* AMD PMF BIOS interfaces */
>>  struct apmf_verify_interface {
>>  	u16 size;
>