Hi, On 2/20/24 13:06, Ilpo Järvinen wrote: > On Tue, 20 Feb 2024, Hegde, Suma wrote: >> On 2/19/2024 6:15 PM, Hans de Goede wrote: >>> On 1/30/24 08:34, Suma Hegde wrote: >>>> HSMP interface is only supported on x86 based AMD EPYC line of >>>> processors. Driver uses ACPI APIs, so make it dependent on CONFIG_ACPI. >>>> >>>> Reported-by: kernel test robot <lkp@xxxxxxxxx> >>>> Closes: >>>> https://lore.kernel.org/oe-kbuild-all/202401281437.aus91srb-lkp@xxxxxxxxx/ >>>> Signed-off-by: Suma Hegde <suma.hegde@xxxxxxx> >>>> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@xxxxxxx> >>> Thank you for your patch, I've applied this patch to my review-hans >>> branch: >>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans >>> >>> Note it will show up in my review-hans branch once I've pushed my >>> local branch there, which might take a while. >>> >>> I will include this patch in my next fixes pull-req to Linus >>> for the current kernel development cycle. > >> This change was merged by Ilpo in review-ilpo branch into commit: >> platform/x86/amd/hsmp: Add support for ACPI based probing. > >>>> diff --git a/drivers/platform/x86/amd/Kconfig >>>> b/drivers/platform/x86/amd/Kconfig >>>> index 54753213cc61..f88682d36447 100644 >>>> --- a/drivers/platform/x86/amd/Kconfig >>>> +++ b/drivers/platform/x86/amd/Kconfig >>>> @@ -8,7 +8,7 @@ source "drivers/platform/x86/amd/pmc/Kconfig" >>>> >>>> config AMD_HSMP >>>> tristate "AMD HSMP Driver" >>>> - depends on AMD_NB && X86_64 >>>> + depends on AMD_NB && X86_64 && ACPI > > Yes, it only belongs to for-next. > > The change that triggered the build fail is (it is only in for-next): Ah, my bad, thank you both for catching this. I have dropped this from my review-hans branch now. Regards, Hans
