On Mon, 19 Feb 2024, Gergo Koteles wrote:
> On Mon, 2024-02-19 at 10:39 +0800, Ike Panhc wrote:
> > On 2/11/24 06:51, Gergo Koteles wrote:
> > > According to the manual, Fn+R adjusts the display refresh rate.
> > > Map Fn+R to KEY_DISPLAYTOGGLE.
> > >
> > > Signed-off-by: Gergo Koteles <soyer@xxxxxx>
> > > +++ b/drivers/platform/x86/ideapad-laptop.c
> > > @@ -1091,6 +1091,8 @@ static const struct key_entry ideapad_keymap[] = {
> > > { KE_KEY, 0x07 | IDEAPAD_WMI_KEY, { KEY_HELP } },
> > > { KE_KEY, 0x0e | IDEAPAD_WMI_KEY, { KEY_PICKUP_PHONE } },
> > > { KE_KEY, 0x0f | IDEAPAD_WMI_KEY, { KEY_HANGUP_PHONE } },
> > > + /* Refresh Rate Toggle (Fn+R) */
> > > + { KE_KEY, 0x10 | IDEAPAD_WMI_KEY, { KEY_DISPLAYTOGGLE } },
> > > /* Dark mode toggle */
> > > { KE_KEY, 0x13 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
> > > /* Sound profile switch */
> >
> > Acked-by: Ike Panhc <ike.pan@xxxxxxxxxxxxx>
> >
> > BTW on which ideapad we need this patch?
> >
>
> Oh, I somehow missed that. I found it on a Yoga 7 14ARB7.
>
> Newer Yogas and Legions with 60Hz/90Hz displays have this refresh rate
> toggle feature.
>
> I'm wondering if this would be worth a new KEY_REFRESH_RATE_TOGGLE
> event code?
>
> KEY_DISPLAYTOGGLE is used to toggle the LCD on/off in other drivers.
>
> What do you think?
At least to me it felt like an abuse of KEY_DISPLAYTOGGLE because it's
obviously different. But since there was existing, similar use for it
already, I didn't push back on it but took your patch.
--
i.
