On Sat, Feb 17, 2024 at 12:36 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 2/16/24 22:24, Andy Shevchenko wrote: > > On Fri, Feb 16, 2024 at 09:17:19PM +0100, Hans de Goede wrote: ... > > The above doesn't explain why the new code is h-file. > > It is in a h file because as metioned: "another driver is in the works" > which will also need this. Implied, but quite unclear. Can you rephrase? > And the code is large/complicated enough that I don't want to copy > and paste it. Yet small enough that it would be silly to put it > in its own .ko file. We have even smaller code in the separate module. So I don't consider this as a strong argument. -- With Best Regards, Andy Shevchenko
