On Fri, Feb 16, 2024 at 09:17:20PM +0100, Hans de Goede wrote: > After commit b286f4e87e32 ("serial: core: Move tty and serdev to be > children of serial core port device") x86_instantiate_serdev() no longer > works due to the serdev-controller-device moving in the device hierarchy > from (e.g.) /sys/devices/pci0000:00/8086228A:00/serial0 to > /sys/devices/pci0000:00/8086228A:00/8086228A:00:0/8086228A:00:0.0/serial0 > > Use the new get_serdev_controller() helper function to fix this. ... > #include "x86-android-tablets.h" > +#include "../serdev_helpers.h" Seems Q more to the previous patch, why is this in the upper folder? Are we expecting more users? -- With Best Regards, Andy Shevchenko