Re: [PATCH v6 067/164] pwm: lpss-*: Make use of devm_pwmchip_alloc() function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Feb 14, 2024 at 10:31:54AM +0100, Uwe Kleine-König wrote:
> This prepares the pwm-lpc drivers to further changes of the pwm core

lpc --> lpss
pwm --> PWM

> outlined in the commit introducing devm_pwmchip_alloc(). There is no
> intended semantical change and the driver should behave as before.


> -struct pwm_lpss_chip *devm_pwm_lpss_probe(struct device *dev, void __iomem *base,
> +struct pwm_chip *devm_pwm_lpss_probe(struct device *dev, void __iomem *base,
>  					  const struct pwm_lpss_boardinfo *info)

Missing indentation amendment for the second line.


> +	struct pwm_chip *chip;
>  	struct pwm_lpss_chip *lpwm;
>  	unsigned long c;
>  	int i, ret;

Please, keep reversed xmas tree order in place.

	struct pwm_lpss_chip *lpwm;
	struct pwm_chip *chip;
	unsigned long c;
	int i, ret;


With the above being addressed,
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>

With Best Regards,
Andy Shevchenko

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux