Hi, I've applied to first two type cleanup patches to review-ilpo. I considered taking patch 3 and 4 already too but I'd like to see the sysfs documentation for the added sysfs files first. On Tue, 13 Feb 2024, Shravan Kumar Ramani wrote: > Add support for programming any counter to monitor the cycle count. > Since counting of cycles using 32-bit ocunters would result in frequent ocunters -> counters > wraparounds, add the ability to combine 2 adjacent 32-bit counters to > form 1 64-bit counter. > Both these features are supported by BlueField-3 PMC hardware, hence Please try to avoid paragraphs like this. Either make it a truly flowing paragraph or insert a newline in between the paragraphs. > the required bit-fields are exposed by the driver via sysfs to allow > the user to configure as needed. > > Signed-off-by: Shravan Kumar Ramani <shravankr@xxxxxxxxxx> > Reviewed-by: David Thompson <davthompson@xxxxxxxxxx> > Reviewed-by: Vadim Pasternak <vadimp@xxxxxxxxxx> -- i.