On Fri, 9 Feb 2024, Shravan Kumar Ramani wrote:
Hi,
You need to provice commit description here too. The shortlog on subject
line is not enough.
> Signed-off-by: Shravan Kumar Ramani <shravankr@xxxxxxxxxx>
> ---
> drivers/platform/mellanox/mlxbf-pmc.c | 121 +++++++++++++-------------
> 1 file changed, 59 insertions(+), 62 deletions(-)
>
> diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
> index b1995ac268d7..71d919832e2a 100644
> --- a/drivers/platform/mellanox/mlxbf-pmc.c
> +++ b/drivers/platform/mellanox/mlxbf-pmc.c
> @@ -149,17 +149,17 @@ struct mlxbf_pmc_block_info {
> */
> struct mlxbf_pmc_context {
> struct platform_device *pdev;
> - uint32_t total_blocks;
> - uint32_t tile_count;
> - uint8_t llt_enable;
> - uint8_t mss_enable;
> - uint32_t group_num;
> + u32 total_blocks;
> + u32 tile_count;
> + u8 llt_enable;
> + u8 mss_enable;
> + u32 group_num;
> struct device *hwmon_dev;
> const char *block_name[MLXBF_PMC_MAX_BLOCKS];
> struct mlxbf_pmc_block_info block[MLXBF_PMC_MAX_BLOCKS];
> const struct attribute_group *groups[MLXBF_PMC_MAX_BLOCKS];
> bool svc_sreg_support;
> - uint32_t sreg_tbl_perf;
> + u32 sreg_tbl_perf;
> unsigned int event_set;
> };
>
> @@ -865,8 +865,8 @@ static struct mlxbf_pmc_context *pmc;
> static const char *mlxbf_pmc_svc_uuid_str = "89c036b4-e7d7-11e6-8797-001aca00bfc4";
>
> /* Calls an SMC to access a performance register */
> -static int mlxbf_pmc_secure_read(void __iomem *addr, uint32_t command,
> - uint64_t *result)
> +static int mlxbf_pmc_secure_read(void __iomem *addr, u32 command,
> + u64 *result)
Please remove unnecessary newlines too such as this one from the function
arguments.
Other than those two things, this one looked fine. Thanks for doing this.
--
i.
