On Thu, 8 Feb 2024, Vishnu Sankar wrote: > Thanks a lot for the review. > And sorry for the delay in response. Small improvements to my earlier version below now that I reread it. > On Tue, Feb 6, 2024 at 8:03 PM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > > @@ -6174,6 +6191,21 @@ static int thermal_get_sensor(int idx, s32 *value) ... > A code reader would be served much better if this convoluted logic is > simplied to: > > case TPACPI_THERMAL_TPEC_12: > if (idx >= 12) > return -EINVAL; > > if (idx <= 7) if (idx < 8) <- to match idx - 8 > ec_offset = TP_EC_THERMAL_TMP0_NS + idx; > else > ec_offset = TP_EC_THERMAL_TMP8_NS + (idx - 8); > > if (!acpi_ec_read(ec_offset, &tmp)) > return -EIO; > > *value = tmp * 1000; 1000 should likely be something from linux/units.h. -- i.
