Re: [PATCH] platform/x86/amd/hsmp: switch to use device_add_groups()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 1/29/2024 6:16 PM, Ilpo Järvinen wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

+ Cc Suma Hegde.

On Sun, 28 Jan 2024, Greg Kroah-Hartman wrote:

The use of devm_*() functions works properly for when the device
structure itself is dynamic, but the hsmp driver is attempting to have a
local, static, struct device and then calls devm_() functions attaching
memory to the device that will never be freed.

The logic of having a static struct device is almost never a wise
choice, but for now, just remove the use of devm_device_add_groups() in
this driver as it obviously is not needed.

Hi Greg,

Could you please hold on merging this patch for a week? I will push a patch for converting platform specific structure's memory allocation from static to a dynamic


Cc: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@xxxxxxx>
Cc: Carlos Bilbao <carlos.bilbao@xxxxxxx>
Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Cc: platform-driver-x86@xxxxxxxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
  drivers/platform/x86/amd/hsmp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c
index b55d80e29139..49ef0b1d6df0 100644
--- a/drivers/platform/x86/amd/hsmp.c
+++ b/drivers/platform/x86/amd/hsmp.c
@@ -471,7 +471,7 @@ static int hsmp_create_sysfs_interface(void)
               if (ret)
                       return ret;
-     return devm_device_add_groups(, hsmp_attr_grps);
+     return device_add_groups(, hsmp_attr_grps);
Thanks Greg for bringing this up. I've added Suma who has some patches
which change code around this area.
Thanks Ilpo for adding me. I will push patch to address above issue on top of "Add ACPI probing support for HSMP" patch series.

Thanks and Regards,


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux