Re: [PATCH vhost 08/17] virtio: vring_new_virtqueue(): pass struct instead of multi parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 31 Jan 2024 13:03:04 +0200 (EET), =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
> On Tue, 30 Jan 2024, Xuan Zhuo wrote:
>
> > Just like find_vqs(), it is time to refactor the
> > vring_new_virtqueue(). We pass the similar struct to
> > vring_new_virtqueue.
> >
> > Signed-off-by: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>
> > ---
>
> > diff --git a/tools/virtio/vringh_test.c b/tools/virtio/vringh_test.c
> > index 98ff808d6f0c..37f8c5d34285 100644
> > --- a/tools/virtio/vringh_test.c
> > +++ b/tools/virtio/vringh_test.c
>
> > @@ -391,7 +391,7 @@ static int parallel_test(u64 features,
> >  				/* Swallow all notifies at once. */
> >  				if (read(to_guest[0], buf, sizeof(buf)) < 1)
> >  					break;
> > -
> > +
> >  				receives++;
> >  				virtqueue_disable_cb(vq);
> >  				continue;
> > @@ -424,7 +424,7 @@ static int parallel_test(u64 features,
> >  				continue;
> >  			if (read(to_guest[0], buf, sizeof(buf)) < 1)
> >  				break;
> > -
> > +
>
> Two unrelated space changes. Please remove them from this patch.


Will fix in next version.

Thanks.


>
>
> --
>  i.
>




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux