Re: [PATCH 0/2] platform/x86: Add ACPI quickstart button driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 31.01.24 um 16:42 schrieb Dennis Nezic:

On 31 Jan 12:16, Armin Wolf wrote:
This patch series adds support for the ACPI PNP0C32 device as
proposed in 2022 by Arvid Norlander. The first patch adds support
for the device itself, while the second patch was taken from the
original series.

Both patches are compile-tested only.

Armin Wolf (1):
   platform/x86: Add ACPI quickstart button (PNP0C32) driver

Arvid Norlander (1):
   platform/x86: toshiba_acpi: Add quirk for buttons on Z830

  MAINTAINERS                         |   6 +
  drivers/platform/x86/Kconfig        |  13 ++
  drivers/platform/x86/Makefile       |   3 +
  drivers/platform/x86/quickstart.c   | 225 ++++++++++++++++++++++++++++
  drivers/platform/x86/toshiba_acpi.c |  36 ++++-
  5 files changed, 280 insertions(+), 3 deletions(-)
No change here in HP Compaq land, except for the existence of this new
Quickstart Button1, no activity is reported via my HP WMI hotkeys or the
Quickstart Button, but rather through AT Translated Set 2 keyboard, as
usual - the same behaviour as not having hp-wmi or quickstart (eg. if I
unload the modules).

[    2.517431] input: HP WMI hotkeys as /devices/virtual/input/input14

[    4.397304] ACPI BIOS Error (bug): AE_AML_BUFFER_LIMIT, Index (0x000000032) is beyond end of object (length 0x32) (20230628/exoparg2-393)
[    4.399581] ACPI Error: Aborting method \_SB.C27D.WQBE due to previous error (AE_AML_BUFFER_LIMIT) (20230628/psparse-529)
[    4.425162] ACPI BIOS Error (bug): AE_AML_BUFFER_LIMIT, Index (0x000000032) is beyond end of object (length 0x32) (20230628/exoparg2-393)
[    4.426760] ACPI Error: Aborting method \_SB.C27D.WQBE due to previous error (AE_AML_BUFFER_LIMIT) (20230628/psparse-529)
[    4.593291] hp_bioscfg: Returned error 0x3, "Invalid command value/Feature not supported"

[    4.606696] input: Quickstart Button 1 as /devices/platform/PNP0C32:00/input/input16

/dev/input/event4 (AT Translated Set 2 keyboard) opened successfully
/dev/input/event6 (HP WMI hotkeys) opened successfully
/dev/input/event8 (Quickstart Button 1) opened successfully


Maybe this HP documentation might help, there are ACPI tables and stuff
mentioned around page 8 ... http://dennisn.mooo.com/stuff/direct-launch.pdf

The issue is that you machine does not support runtime button events on the quickstart button,
only wake events.

Can you check if you can now use the unresponsive button to wake the system?

Armin Wolf





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux