Hi, On 1/8/24 13:25, Hans de Goede wrote: > Hi, > > On 1/8/24 12:18, Ilpo Järvinen wrote: >> On Sun, 7 Jan 2024, Hans de Goede wrote: <snip> >>> + >>> + /* Low part */ >>> + pmc_dev_state_check(d3_sts_0, m->d3_sts_0, func_dis, m->func_dis, false_pos_sts_0); >>> + >>> + /* High part */ >>> + pmc_dev_state_check(d3_sts_1, m->d3_sts_1, func_dis_2, m->func_dis_2, false_pos_sts_1); >> >> The variables are called _0 and _1 but the comment talks about "low" and >> "high", could these be made consistent such that variabless end into _lo & >> _hi ? >> >> After making that change, I don't think those comments add any value any >> further value to what is already plainly visible from the code itself. > > Ack, I'll replace the _0 and _1 with _lo and _hi. Correction the _0 and _1 actually match the name of the register address defines, which in turn mach the data sheet names. so instead of replacing _0 / _1 I have no dropped the /* Low part */ and /* High part */ comments since those are a bit off. Regards, Hans
