Hi, On 12/24/23 23:03, Pali Rohár wrote: > On Sunday 24 December 2023 22:36:21 Hans de Goede wrote: >> Instead of instantiating an i2c_client for the old misc joystick emulation >> and freefall driver: drivers/misc/lis3lv02d/lis3lv02d.c use >> i2c_client_id-s from the IIO st_accel driver so that the accelerometer >> gets presented to userspace as an IIO device like all modern accelerometer >> drivers do. >> >> Add a new use_misc_lis3lv02d module-parameter which can be set to restore >> the old behavior in case someone has a use-case depending on this. >> >> When the st_accel IIO driver is used, also pass the IRQ to the i2c_client >> and disable the /dev/freefall chardev. >> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> drivers/platform/x86/dell/dell-smo8800.c | 82 ++++++++++++++++++++++-- >> 1 file changed, 78 insertions(+), 4 deletions(-) > > Sorry for the stupid question there, but what is the replacement for the > /dev/freefall when using new st_accel IIO driver? There is no replacement for /dev/freefall. I realize this is not ideal and if this turns out to be a problem the default of the module option can be reverted. But AFAIK / AFAICT there are no actual userspace consumers of /dev/freefall so removing it should not be an issue. Specifically I checked smartmontools which ships smartd which is the only daemon which I know of for hdd monitoring and that does not have /dev/freefall support. So /dev/freefall appears to be unused to me ? For completeness I also checked libatasmart which also does not access /dev/freefall. Regards, Hans
