Hi Jiapeng, On 12/29/23 03:08, Jiapeng Chong wrote: > The lnl_d3_fixup are not used outside the file lnl.c, so the > modification is defined as static. > > drivers/platform/x86/intel/pmc/lnl.c:503:6: warning: no previous prototype for ‘lnl_d3_fixup’. > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7811 > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Thank you for your patch, but this has already been fixed in the current version of the code, see: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/tree/?h=for-next Regards, Hans > --- > drivers/platform/x86/intel/pmc/lnl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c > index 88b35931f5df..f18fdc68fd94 100644 > --- a/drivers/platform/x86/intel/pmc/lnl.c > +++ b/drivers/platform/x86/intel/pmc/lnl.c > @@ -500,7 +500,7 @@ const struct pmc_reg_map lnl_socm_reg_map = { > * Set power state of select devices that do not have drivers to D3 > * so that they do not block Package C entry. > */ > -void lnl_d3_fixup(void) > +static void lnl_d3_fixup(void) > { > pmc_core_set_device_d3(LNL_IPU_PCI_DEV); > pmc_core_set_device_d3(LNL_NPU_PCI_DEV);
