On Sun, Dec 31, 2023 at 6:33 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Extend the s2idle check with checking that none of the PMC clocks
> is in the forced on state. If one of the clocks is in forced on
Perhaps "forced-on state"?
> state then S0i3 cannot be reached.
...
> +#define PMC_CLK_CTL_OFFSET 0x60
> +#define PMC_CLK_NUM 6
> +#define PMC_CLK_CTL_GATED_ON_D3 0x0
> +#define PMC_CLK_CTL_FORCE_ON 0x1
> +#define PMC_CLK_CTL_FORCE_OFF 0x2
> +#define PMC_CLK_CTL_RESERVED 0x3
> +#define PMC_MASK_CLK_CTL GENMASK(1, 0)
Please, move these to include/linux/platform_data/x86/clk-pmc-atom.h
from drivers/clk/x86/clk-pmc-atom.c and use the former. Otherwise it's
a big dup of the existing stuff.
...
> + pr_err("pmc_atom: clk %d is ON prior to freeze (ctl %08x)\n", i, ctl);
No prefix.
--
With Best Regards,
Andy Shevchenko
