Hi Armin, On 12/16/23 02:55, Armin Wolf wrote: > This patch series improves the ACPI handling inside the ACPI WMI driver. > The first patch removes an unused variable, while the second patch > changes the order in which the ACPI handlers are removed on shutdown. > The third patch simplifies the error handling during probe by using > devres to manage devie resources, while the next two patches decouple > the ACPI notify handler from the wmi_block_list. The last patch > simplifies yet another ACPI-related function. > > All patches have been tested on a Dell Inspiron 3505 and appear to work. > > Armin Wolf (6): > platform/x86: wmi: Remove unused variable in address space handler > platform/x86: wmi: Remove ACPI handlers after WMI devices > platform/x86: wmi: Use devres for resource handling > platform/x86: wmi: Create WMI bus device first > platform/x86: wmi: Decouple ACPI notify handler from wmi_block_list > platform/x86: wmi: Simplify get_subobj_info() > > drivers/platform/x86/wmi.c | 143 ++++++++++++++++++------------------- > 1 file changed, 71 insertions(+), 72 deletions(-) Thank you for the series, with the exception of the one small remark to patch 3/7 the entire series looks good to me. With that remark addressed you may add my: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> to the series. Regards, Hans > > -- > 2.39.2 >
