Hi, On 12/14/23 15:52, Ilpo Järvinen wrote: > On Thu, 14 Dec 2023, Vishnu Sankar wrote: > >> Some ThinkPad systems ECFW use non-standard addresses for fan control >> and reporting. This patch adds support for such ECFW so that it can report >> the correct fan values. >> Tested on Thinkpads L13 Yoga Gen 2 and X13 Yoga Gen 2. >> >> Suggested-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> >> Signed-off-by: Vishnu Sankar <vishnuocv@xxxxxxxxx> >> --- >> -Improvements to comments as requested. >> -Removed the usage of unlikely/likely while reading fan speed. >> -Improved and clearer print statements to match the current style. >> -Changed seq_puts to seq_printf of an unrelated section of the patch. >> -Improved the readability of the code. >> -Added more clearer comments. > > Nice work, thanks. > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> Ilpo, thank you for the review. The patch looks good to me too: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Ilpo, do you plan on sending out one more fixes pull-req for 6.7 and if yes, can you add this patch to that; or shall I merge this into for-next so that it gets included in 6.8-rc1 ? Regards, Hans
